fix(proto): bring proto/ to parity with codebase #57
Merged
wasabi opened 5 days ago

Summary

Fixes bugs and adds documentation for the proto directory.

Changes

Bug Fixes

  • proto/buf.yaml: fixed module path path: protopath: . — buf.yaml is inside proto/, so the old path resolved to proto/proto/ (doesn't exist). buf lint and buf generate were broken.
  • services/grpc/data_service.py: added missing import grpcgrpc.StatusCode.NOT_FOUND was called without import, causing NameError at runtime on not-found paths.
  • services/grpc/credit_class_service.py: same fix — 5 occurrences of grpc.StatusCode.NOT_FOUND without import.

Documentation

  • proto/README.md — documents directory structure, both services (46 RPCs total), code generation workflow (Dockerfile.grpc + buf), linting, and how to add new RPCs.

Verification

  • buf.yaml path: . correctly resolves proto files at proto/common/, proto/data/v1/, proto/ecocredit/v1/
  • import grpc confirmed in both service files
  • No whitespace errors
Commits were merged into target branch
1/1
Submitter wasabi
Target main
Source feat/proto-parity
Jobs
Merge Strategy
Create Merge Commit
Watchers (1)
Reference
pull request KI-57
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover