fix(upgrades): close upgrade system definition-of-done gaps (KI-87)

fix(upgrades): close upgrade system definition-of-done gaps #87

Merged

wasabi opened 2 days ago

Summary

Closes the remaining upgrade-system Definition-of-Done gaps identified after KI-86.

Changes

Injects the checked-out git SHA into Compose application services and verifies version/SHA from inside the Compose network.
Adds scripts/verify-upgrade.sh and makes it the default post-upgrade verifier.
Removes the normal upgrade backup bypass; every upgrade now creates a checkpoint.
Moves the canonical pilot organization out of normal/reference seeding and keeps it in seed-pilot.sh.
Extends advisory locking to migration tracking initialization and legacy reconciliation.
Adds disposable PostgreSQL and ClickHouse checkpoint restore coverage.
Exercises the explicit rollback path in CI using isolated databases.
Adds CI configuration for backup encryption and application SHA verification.

Verification

KOKONUT_ALLOW_PLAINTEXT_ENV=true .venv/bin/python -m pytest tests/test_migration.py tests/test_upgrade.py tests/test_upgrade_integration.py -q
26 passed, 1 expected local-only integration skip.
Shell syntax validation passed for upgrade, verifier, backup, restore, rollback, and seed scripts.
Ruff passed for changed Python files.
Development and production Compose configurations validated.
CI-only integration test provisions isolated PostgreSQL and ClickHouse databases, creates a verified checkpoint, drops/recreates both, and restores them through the rollback path.

Commits were merged into target branch

feat(upgrades): verify release identity inside Compose

2 days ago

55741b83

fix(upgrades): enforce checkpoints and isolate pilot seeds

2 days ago

3d87d88d

test(upgrades): exercise disposable restore and rollback

2 days ago

febbd80b

fix(upgrades): remove verifier formatting drift

2 days ago

d80baf08
fix(ci): diagnose and verify grpc health

2 days ago

d05f405c
fix(ci): pass grpc database credentials

2 days ago

9991e327
fix(ci): stabilize gateway and grpc healthchecks

2 days ago

86657018
fix(ci): rebuild application images

2 days ago

54ecf6a6
fix(grpc): exempt health checks with wire method paths

2 days ago

ac4592e4
fix(grpc): start server before health checks

2 days ago

7b764afe
fix(ci): invoke upgrade verifier with bash

2 days ago

1345fec9

fix(ci): inline upgrade verification to avoid compose project name mismatch

Replace bash ./scripts/verify-upgrade.sh invocation with inline
docker compose exec using the same -f flags as every other CI step.
The script's --project-directory flag caused a compose project name
mismatch with the running containers (exit code 127).

The healthchecks already confirmed all services are healthy before
this step; the inline check only verifies version + git SHA via the
gateway, which is the one thing healthchecks don't cover.

2 days ago

6a941cb8

wasabi merged 2 days ago
Login to comment

Submitter	wasabi
Target	main
Source	fix/upgrade-dod-gaps

Jobs

Merge Strategy

Create Merge Commit

Watchers (1)

Reference

pull request KI-87